Repository navigation
Contact and Privacy: use the shared settings, ContactLinks and date formatting - #212
Merged
Merged
Conversation
…ormatting Both pages now read site settings through getSiteSettings and render contact details with ContactLinks, and use getLocale, pageMetadata, routes, PageShell and PageHeader. Privacy formats its date with a new formatLongDate (en-IE / ga-IE) and its page-private helpers move to features/privacy. CONTACT_SETTINGS_QUERY has no users left and is removed. Closes #188 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #188
What changed
contactandprivacypages usegetLocale,pageMetadata,routes,PageShellandgetSiteSettings+ContactLinks(contact:definitions, privacy:list). Suspense boundaries and skeletons are unchanged, and the contact header still reads published content only (draft: false) so it stays static.formatLongDate(iso, locale)inlib/dates.tswith tests. It takes a locale tag like its siblings (formatShortDate), so privacy calls it withdateLocale[lang].Section,BulletList,slug,StorageGroupandWithLinkmove tofeatures/privacy/components/.WithLinkstays private since no other page uses it.CONTACT_SETTINGS_QUERYis deleted (no users left).PAGE_TEXT_QUERY/sanity/lib/pageText.tsare kept: work, talent, rentals and quote still usegetPageText. Whichever of Work: add loaders and slim down the pages #185–Rentals (hidden): add loaders, a slug-based catalogue, one MAX_QTY and the feature flag #189 removes the last use deletes them, otherwise Remove dead code and add knip to CI #192.Visible differences
en→en-IE, so "8 November 2026" instead of "November 8, 2026". Irish is "8 Samhain 2026".listvariant: the email istext-lgwith a screen-reader label, and Instagram shows if set (it didn't before). The contact-form link is now a<p>instead of an<li>.Checks
typecheck,lint,testpass.format:checkonly flags.impeccable/hook.cache.json, which is gitignored./contact,/privacy,/ga/contact,/ga/privacy(200, expected dates, mailto and Instagram links).contact,a11y) not run locally: the seed needsSANITY_API_WRITE_TOKEN, which isn't available here.🤖 Generated with Claude Code